-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor publicAccessControl
#40
Comments
@sshivaditya2019 looks like it appended similarity even with no results. Ensure that doesn't happen! |
/start |
Tip
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
1 similar comment
@YanVictorSN, this task has been idle for a while. Please provide an update. |
Just waiting a review. Already open a PR. |
Passed the deadline and no activity is detected, removing assignees: @YanVictorSN. |
@YanVictorSN the deadline is at Fri, Nov 8, 3:23 AM UTC |
A new workroom has been created for this task. Join chat |
Passed the deadline and no activity is detected, removing assignees: @YanVictorSN. |
I realize that contributors cant add labels unless there is an issue template that allows them to create an issue and select labels when creating issues, but this is an unusual scenario that projects need to go out of their way for.
publicAccessControl.setLabel
publicAccessControl
to only be a boolean called:fundContributorClosedIssue
, default is false.https://github.com/ubiquity-os-marketplace/assistive-pricing/blob/9984131a66eb9167dd0f60147a99e41ae382c43b/src/types/plugin-input.ts#L23-L29
Note
The reason why
fundContributorClosedIssue
exists is because if:Then they can mark the issue closed as completed using the GitHub UI (because they created the issue) which makes an easy attack vector.
Similar [^01^]
The text was updated successfully, but these errors were encountered: