Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publicAccessControl #40

Open
0x4007 opened this issue Oct 3, 2024 · 10 comments
Open

Refactor publicAccessControl #40

0x4007 opened this issue Oct 3, 2024 · 10 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 3, 2024

I realize that contributors cant add labels unless there is an issue template that allows them to create an issue and select labels when creating issues, but this is an unusual scenario that projects need to go out of their way for.

  • Remove all references to publicAccessControl.setLabel
  • Refactor publicAccessControl to only be a boolean called: fundContributorClosedIssue, default is false.

https://github.com/ubiquity-os-marketplace/assistive-pricing/blob/9984131a66eb9167dd0f60147a99e41ae382c43b/src/types/plugin-input.ts#L23-L29

Note

The reason why fundContributorClosedIssue exists is because if:

  1. an outside party files an issue
  2. we fund it
  3. self assign

Then they can mark the issue closed as completed using the GitHub UI (because they created the issue) which makes an easy attack vector.

Similar [^01^]
@0x4007
Copy link
Member Author

0x4007 commented Oct 3, 2024

@sshivaditya2019 looks like it appended similarity even with no results. Ensure that doesn't happen!

@YanVictorSN
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Oct 8, 2024

Deadline Tue, Oct 8, 10:30 PM UTC
Beneficiary 0xF51cFA5eb9128F064eafb75524502A039F063D91

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

@YanVictorSN, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Oct 14, 2024

@YanVictorSN, this task has been idle for a while. Please provide an update.

@YanVictorSN
Copy link

@YanVictorSN, this task has been idle for a while. Please provide an update.

Just waiting a review. Already open a PR.

Copy link

Passed the deadline and no activity is detected, removing assignees: @YanVictorSN.

Copy link

@YanVictorSN the deadline is at Fri, Nov 8, 3:23 AM UTC

Copy link

A new workroom has been created for this task. Join chat

Copy link

Passed the deadline and no activity is detected, removing assignees: @YanVictorSN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants