-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typebox error handling and issue feedback #96
Comments
/start |
Tips:
|
/wallet |
@tiilliir, this task has been idle for a while. Please provide an update. |
1 similar comment
@tiilliir, this task has been idle for a while. Please provide an update. |
A double follow up with no update is unusual @gentlementlegen @Keyrxng can you guys investigate |
Looks like we need to exclude events like {
id: 14254408264,
node_id: 'MEE_lADOLUK0B86UFNt9zwAAAANRoQJI',
url: 'https://api.github.com/repos/ubiquibot/conversation-rewards/issues/events/14254408264',
actor: {
login: 'tiilliir',
id: 180199616,
node_id: 'U_kgDOCr2gwA',
type: 'User',
site_admin: false
},
event: 'mentioned',
commit_id: null,
commit_url: null,
created_at: '2024-09-13T20:55:35Z',
performed_via_github_app: null
} {
id: 14254408270,
node_id: 'SE_lADOLUK0B86UFNt9zwAAAANRoQJO',
url: 'https://api.github.com/repos/ubiquibot/conversation-rewards/issues/events/14254408270',
actor: {
login: 'tiilliir',
id: 180199616,
node_id: 'U_kgDOCr2gwA',
type: 'User',
site_admin: false
},
event: 'subscribed',
commit_id: null,
commit_url: null,
created_at: '2024-09-13T20:55:35Z',
performed_via_github_app: null
} Can either of you think of other events we might need to handle and I or someone can look into it further via a task? mentioned, subscribed, unsubscribed, reactions, comment.deleted and edited too I'd say... |
Not sure. Let's iterate until we get it right. |
Actually, perhaps it makes sense to do a whitelist approach.
I think thats it for now. |
@tiilliir, this task has been idle for a while. Please provide an update. |
1 similar comment
@tiilliir, this task has been idle for a while. Please provide an update. |
/start |
Tip
|
Passed the deadline and no activity is detected, removing assignees: @himanshuranjan007. |
An issue exists with the usage of
T.Union
which should be investigated and resolved.It would also be handy to improve user feedback on the issue as a user must head to the workflow run to get a hint at what is going on.
I'm unsure what labels to assign, you would know better @gentlementlegen
original context
The text was updated successfully, but these errors were encountered: