Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete confirmation modal in ImageManager #940

Open
jumbosushi opened this issue May 17, 2019 · 0 comments
Open

Add delete confirmation modal in ImageManager #940

jumbosushi opened this issue May 17, 2019 · 0 comments

Comments

@jumbosushi
Copy link
Contributor

jumbosushi commented May 17, 2019

What behavior were you expecting?

When I click delete button in ImangeManager from ArticleEditors, I expect to see delete confirmation modal.

ImageManager delete button in ArticleEditor
article-error

/images/ delete confirmation modal example
image

What actually happened?

No delete confirmation modal popped up. This could lead to images being deleted accidentally

Steps to reproduce

(Try this in your local server NOT on prod)
0. Go to /admin/articles/new

  1. Click on Featured Image Tab
  2. Click "Select Image" to open ImageManager
  3. Try to delete any image

What was your environment like?

Google Chrome 74.0.3729.157 on Ubuntu 16.04 LTS

Getting Started

Look at how <ConfirmButtom/> (code link) is being used in <ListItemToolbar/> component (code link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant