Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix question bank validation bug #41

Open
dmols opened this issue Aug 26, 2024 · 0 comments · May be fixed by #42
Open

Fix question bank validation bug #41

dmols opened this issue Aug 26, 2024 · 0 comments · May be fixed by #42
Assignees

Comments

@dmols
Copy link
Contributor

dmols commented Aug 26, 2024

The Question Bank feature allows the user to decide how many of the pairs to show in the player side. The value used is set manually and it can't go below or over a specific range, but it's currently not listening to user changes such as deleting question-answer pairs. This invites a very odd case where the question bank does not work as intended when moving to the player. For this reason, the simplest solution is to make the question bank value the minimum number between itself and the total pair count, on save, for starters.

@dmols dmols self-assigned this Aug 26, 2024
@dmols dmols linked a pull request Aug 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@dmols and others