-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labeling: Creator and Player should use matching fonts on the labels #5
Comments
QAing |
https://clu.cdl.ucf.edu/materia/labeling/commits/issue/579-matching-label-fonts Fonts now match, however font sizes don't. My goal is to make those labels 100% identical. Looked into it - if you search the project for fontSize you'll find nearly identical code that modifies the fontSize as you type. These should be turned into a reusable method so that the code can be the same and use the same values. The code should use the 15 magic value instead of the 16 magic value as 15 is what is used in the player and that is what was using Roboto Slab originally. |
|
Made a private method in the player and creator that sets font size the same way as one another. Also merged in the current labeling master branch. To QA:
|
Merged master in to incorporate the super-build mega changes. Followed Sam's testing steps. Fonts on both creator and player look the same in both Devmateria and Materia. LGTM |
They're different currently which is unexpected
The text was updated successfully, but these errors were encountered: