Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor is slow to open in remote scenarios. #33

Open
eugeneo opened this issue Sep 6, 2024 · 3 comments
Open

Editor is slow to open in remote scenarios. #33

eugeneo opened this issue Sep 6, 2024 · 3 comments
Assignees

Comments

@eugeneo
Copy link
Member

eugeneo commented Sep 6, 2024

Disassembling the larger executable can take up to several seconds on my WSL2 setup. It opens instantly on another machine that's local. I suspect this has to do with SSH.

A way to only transfer relevant data needs to be identified. I believe this ties into a bigger issue where we need to help the users to see the information that's relevant to them.

@aharbii aharbii self-assigned this Oct 19, 2024
@aharbii
Copy link
Collaborator

aharbii commented Oct 20, 2024

Hi @eugeneo, with some research, I think the approach we may go for doing this is to provide to user the ability to specify a specific function when requesting a preview, so he can enter some arguments for "--disassemble=" flag or choose to request the full disassembly.

In most of cases, if the user knows what he wants to search for he can directly request the disassembly for this section, and what we can support with, if he enables the option of autosave, we can save the full file assembly in background.

the initial logic for the proposal is pushed to branch 'feature/optimizing_fetching_performance'

SectionPreview.webm

@aharbii
Copy link
Collaborator

aharbii commented Oct 20, 2024

also for the checking the sources used to build a binary, we can use -g argument with object dump, and parse the output to get the binaries.

objdump -g examples/vector_debug > examples/vector_debug_debugging.objdump
objdump -g examples/vector_debug | grep '\.cpp\|\.c\|\.cc' > examples/vector_debug_sources.txt

if you got time, please take a look at the examples folder in the listed branch, and also try those commands with the larger binaries, it's kinda stable with debug builds, but trickey as expected with release ones

@eugeneo
Copy link
Member Author

eugeneo commented Oct 22, 2024

This definitely seems to be the right direction!
See what GodBolt does. It shows disassembly that correlates to the lines being hovered over and even highlights the code compiler generates:

Recording.2024-10-21.185447.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants