Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: allow sequential quotes in CLI input #1488

Open
majorsylvie opened this issue May 20, 2022 · 4 comments
Open

cli: allow sequential quotes in CLI input #1488

majorsylvie opened this issue May 20, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@majorsylvie
Copy link
Contributor

team members: Miles, Matteo, Faruk

this is an extension of the quotation-as-one-token issue from before, where we want to allow multiple quotation groups to be made in a single CLI input

@majorsylvie
Copy link
Contributor Author

I updated the malloc call in parse to calloc in order to avoid manually allocating to 0

@mrestuccia1
Copy link

This task was never implemented, as it would have changed much of the previous code we had just written in the recently merged quotes PR. However, here is one idea for implementing it:

  • Use a stack-like algorithm to track whether quotes are open are closed. Because both the open and closing quotes are the same characters, it will have to be a variation of it, likely which tracks whether an even number of quote characters is present.

@mrestuccia1
Copy link

mrestuccia1 commented May 28, 2022

For this issue, Faruk and I worked on the documentation. Miles and I looked over the current dev code for some time to figure out how to make the change, but I decided this might be better suited to leave to future classes since it is not a very urgent feature to add, and would have caused many changes over recently added code.

@jacknugent1529
Copy link
Contributor

Opening this and placing it in the backlog so future teams can work on it

@jacknugent1529 jacknugent1529 reopened this Jun 7, 2022
@jacknugent1529 jacknugent1529 modified the milestones: 2022/Sprint 4, Backlog Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants