Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uppercase letters in inventory item names for the "view inventory" command and skill names for the "view skills" command #1729

Open
HarrisonD123 opened this issue Jun 3, 2022 · 0 comments

Comments

@HarrisonD123
Copy link
Contributor

HarrisonD123 commented Jun 3, 2022

Currently, the "view inventory" and "view inventory [inventory-item]" commands don't support uppercase letters in inventory item names. This is because the CLI team lowercases all strings inputted by the user before passing them to our do_action functions. This causes our display_inventory and display_inventory_item functions in game-state/player.c to be unable to find items with capital letters, given that they are passed lowercased strings. This should be a fairly simple fix that involves ignoring capitalization in the display_inventory and display_inventory_item functions.

The same applies to skills in the display_tree and display_skill_description functions in skilltrees/skilltree.c for the "view skills" and "view skills [skill-name]" commands.

@HarrisonD123 HarrisonD123 changed the title Support uppercase letters in inventory item names for "view inventory" command Support uppercase letters in inventory item names for the "view inventory" command and skill names for the "view skills" command Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant