Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper installation guidelines #119

Open
samvelyan opened this issue Oct 31, 2022 · 5 comments
Open

Proper installation guidelines #119

samvelyan opened this issue Oct 31, 2022 · 5 comments
Assignees

Comments

@samvelyan
Copy link
Member

The users should be able to run the framework following ONLY the installation guide.

I think easiest to use via conda.

@akbir
Copy link
Member

akbir commented Nov 16, 2022

hard veto on conda - i think this is all pip installable!

@akbir
Copy link
Member

akbir commented Nov 16, 2022

like we don’t need auto install binaries so feels like conda is overkill

@akbir
Copy link
Member

akbir commented Nov 16, 2022

@newtonkwan - can you update the install details and look at making pax a package?

@samvelyan
Copy link
Member Author

what does pip-installable have to do with having conda environments for your py projects?

@akbir
Copy link
Member

akbir commented Nov 17, 2022

So the way I see it, conda is a system package manager vs pip is a python package manager.

You should use conda (or suggest it to users) when you need to install things that are not just in python. For example - torch or opencv, where the dependencies are C++ binaries or other libraries (e.g. libjpeg-turbo).

Just like most other packages in the Jax eco-system you don't need to specify any additional binaries (e.g evosax, Chex, rlax) - the user is assumed to have jax already installed. I think it would be good to keep to that standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants