Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRFI 1: List Library #22

Open
lassik opened this issue Apr 20, 2020 · 7 comments
Open

SRFI 1: List Library #22

lassik opened this issue Apr 20, 2020 · 7 comments

Comments

@lassik
Copy link
Collaborator

lassik commented Apr 20, 2020

https://srfi.schemers.org/srfi-1/srfi-1.html

@lassik lassik mentioned this issue Apr 20, 2020
@lassik
Copy link
Collaborator Author

lassik commented Apr 20, 2020

We should clear up the copyright status of the implementations in the repo.

The main file is: https://github.com/udem-dlteam/libs/blob/master/srfi/1/1.scm

It is based on Olin's code from the sample implementation of the SRFI.

@alvatar Can you check whether there is some of your code in the implementation? If so, let's add a copyright line for you to the source file.

@lassik
Copy link
Collaborator Author

lassik commented Apr 20, 2020

@feeley Can you do a quick review of 1.scm for coding style? It's clean and straightforward code but there may be some easy opportunities Gambit-specific optimizations or to make error checking more idiomatic.

@lassik
Copy link
Collaborator Author

lassik commented Apr 20, 2020

A lot of code is commented out in that file. We should probably remove it once we have understood what it did. All tests pass without the commented-out code.

@feeley
Copy link
Member

feeley commented Apr 27, 2020

OK, so now we have the start of the gambit/list module which aims to be a superset of SRFI 1. So we should work mostly in gambit/list and later implement SRFI 1 trivially as a library that reexports a subset of the gambit/list exports. The same for gambit/string and SRFI 13/152.

@lassik
Copy link
Collaborator Author

lassik commented Apr 27, 2020

Perfect! I'm just compiling master.

Are there particular SRFIs you plan to have fully implemented for Gambit's upcoming release?

@lassik
Copy link
Collaborator Author

lassik commented Apr 27, 2020

In my experience 1 (list), 13 (string), 132 (sort), 151 (bitwise) are constantly needed. These should be pretty easy to fully implement now that the groundwork is laid.

@feeley
Copy link
Member

feeley commented Apr 27, 2020

Yes that would be a good start. The release is still a few weeks in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants