Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactoring #4

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Major refactoring #4

merged 2 commits into from
Jan 26, 2022

Conversation

jbouse
Copy link
Member

@jbouse jbouse commented Jan 12, 2022

what

  • Added documentation
  • Standardize module design framework
  • Addressed deficiencies reported

why

* Remove provider block from module
* Remove aws.use1 provider reference on resources
* Add terraform-null-label module for context support
* Update input from `zone_ids` to `zones`
* Use terraform-aws-kms-key module for KMS key creation
* Use build-harness framework

Signed-off-by: Jeremy T. Bouse <[email protected]>
Signed-off-by: Jeremy T. Bouse <[email protected]>
@jbouse jbouse added documentation Improvements or additions to documentation enhancement New feature or request major labels Jan 12, 2022
@jbouse jbouse merged commit 10b9266 into main Jan 26, 2022
@jbouse jbouse deleted the devel branch January 26, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove module specific tags For_each vpc_id depends on apply first Remove provider region for KMS-CMK
1 participant