Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails are rendered without context data #426

Open
perepicornell opened this issue Oct 19, 2022 · 2 comments
Open

Emails are rendered without context data #426

perepicornell opened this issue Oct 19, 2022 · 2 comments

Comments

@perepicornell
Copy link

Hello!

All the {{ something }} template tags in the are being ignored and shown empty, instead of being replaced with the context data.

In my setup, I'm using the django.core.mail.backends.console.EmailBackend backend, and DEFAULT_PRIORITY is now.

The stdout log using the 3.6.2 version:

Hi ha una nova sol·licitud d'alta avui  a les .

Tipus: 
Nom: 
Accés a la fitxa: 

Running the same after downgrading to the 3.6.1 version:

Hi ha una nova sol·licitud d'alta avui 19/10/2022 a les 15:36.

Tipus: Entitat
Nom: prova via api nom comercial
Accés a la fitxa: https://localhost/admin/partners/entity/8a12fb17-597b-4807-ae0c-259221aeef9c/change/

I imagine that this other issue talks about the same, and the PR might fix it, but I'm not sure if my case is about re-rendering anything so I thought it could be useful to open this other issue, for those who might be googling about the problem.

Many thanks to all the contributors for maintaining this awesome library.

Cheers,
Pere

@zagl
Copy link
Contributor

zagl commented Oct 21, 2022

You may try my current version which includes the changes of this pull request already and two other bug fixes for v3.6.2 and see if it fixes your problem.

You just have to install (maybe in a new virtual environment) my current version from github via pip:

pip uninstall django-post-office
pip install git+https://github.com/zagl/[email protected]

Here you can see the changes in comparison to current post_office master:

master...zagl:django-post_office:development

You can always go back to the official version by:

pip uninstall django-post-office
pip install django-post-office

@kakulukia
Copy link
Contributor

@zagl thx for the fix, as we just got an empty mail and i was glad there is an updated version to solve this since an hour ago. :D

So this ticket can also be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants