Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing property when attempting to supply a linux useragent #405

Open
A-Posthuman opened this issue Dec 22, 2021 · 3 comments
Open

Missing property when attempting to supply a linux useragent #405

A-Posthuman opened this issue Dec 22, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@A-Posthuman
Copy link

agent = await new Agent( { maxConcurrency: 1, userAgent: 'Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4314 Safari/537.36' } );

Cannot read properties of undefined (reading 'length')","metadata":{"name":"TypeError","stack":"TypeError: Cannot read properties of undefined (reading 'length')\n at new BrowserData (/home/ubuntu/plugins/default-browser-emulator/lib/BrowserData.ts:34:26)

also a 1 character typo in the docs on the Agent page for userAgent the type is Strong instead of String.

Is attempting to use a linux UA not possible currently? I notice there don't seem to be any available emulators.

@blakebyrnes
Copy link
Contributor

We currently don't have any supported linux emulators. When we were building the emulators, we were using data from statcounter to determine which operating systems represent the bulk of traffic. Chrome's latest couple versions on mac and windows are the big lump of traffic. Linux was so small that it seemed like you're actually putting yourself into an outlier bucket by using it.

All that said, at some point we will be able to just pick the closest engine and run with whatever data we've got. That's logged in another TODO ticket.

Thanks for the typo :)

@blakebyrnes
Copy link
Contributor

I should note: we don't have mobile. Obviously Android is a big chunk. Desktop linux is the one that is very small (https://gs.statcounter.com/os-market-share/desktop/worldwide/#monthly-202011-202111)

@blakebyrnes blakebyrnes added the good first issue Good for newcomers label Jan 28, 2022
@blakebyrnes
Copy link
Contributor

I don't think we can/will support Linux agents in the short term since they create a detection angle and are too small an audience to warrant generating all the profile data. However, this error should be better.

Would like to improve the error messages when a profile is unsupported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants