Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataModel removed in ss4-beta4 #167

Open
jackoconnor21 opened this issue Oct 25, 2017 · 4 comments
Open

DataModel removed in ss4-beta4 #167

jackoconnor21 opened this issue Oct 25, 2017 · 4 comments

Comments

@jackoconnor21
Copy link

DataModel has been removed in ss4-beta4 and so is causing breaks in GridFieldBetterButonsItemRequest.php on lines 75 & 89.
@tim-lar
Copy link

tim-lar commented Nov 8, 2017

also, the class SilverStripe\ORM\Versioning\Versioned has moved to SilverStripe\Versioned\Versioned

@mr-macedawg
Copy link

#170
Hopefully @unclecheese approves this. I have manually made these changes on my site to confirm it works.

@Martimiz
Copy link

Martimiz commented Dec 5, 2017

Hi uncle, all

Namespace also needs fixing in BetterButtonDataObject, just noticed...

Has anyone got this working for versioned dataobjects yet? Even with these fixes, for me the cms (4 stable) just hangs on loading (page reload)...

@silverstripe-elliot silverstripe-elliot mentioned this issue Jan 18, 2018
Closed
@silverstripe-elliot
Copy link

silverstripe-elliot commented Jan 18, 2018 •
edited
Loading

I have raised a PR for this here: #172

I have closed my PR, somebody else has raised one here: #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Martimiz @tim-lar @silverstripe-elliot @jackoconnor21 @mr-macedawg