Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect redirection when a Versioned DataObject is published #174

Open
shaunjc opened this issue Mar 14, 2018 · 2 comments
Open

Incorrect redirection when a Versioned DataObject is published #174

shaunjc opened this issue Mar 14, 2018 · 2 comments

Comments

@shaunjc
Copy link

shaunjc commented Mar 14, 2018

if ($redirectURL) {
return $controller->redirect($redirectURL);
}

$redirectURL is actually a \SilverStripe\Forms\FormRequestHandler instance, so users are always forced to incorrectly redirect to /SilverStripe/Forms/FormRequestHandler whenever a Versioned DataObject is published. Additional checks to ensure $redirectURL is a string should be added, or these lines should be removed.

@andreaslindahl
Copy link

Any news on this? Will it be fixed?

@unclecheese
Copy link
Owner

The SS4 upgrade is very much in flux, and I'm looking to wrap it up this week. See the feature/ss4-upgrade branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants