From ee02bb388f3636c482c2ffd4c55fd233e050aaf2 Mon Sep 17 00:00:00 2001 From: undergroundwires Date: Sat, 28 Oct 2023 02:19:11 +0200 Subject: [PATCH] Improve UI performance by optimizing reactivity - Replace `ref`s with `shallowRef` when deep reactivity is not needed. - Replace `readonly`s with `shallowReadonly` where the goal is to only prevent `.value` mutation. - Remove redundant `ref` in `SizeObserver.vue`. - Remove redundant nested `ref` in `TooltipWrapper.vue`. - Remove redundant `events` export from `UseCollectionState.ts`. - Remove redundant `computed` from `UseCollectionState.ts`. - Remove `timestamp` from `TreeViewFilterEvent` that becomes unnecessary after using `shallowRef`. - Add missing unit tests for `UseTreeViewFilterEvent`. - Add missing stub for `FilterChangeDetails`. --- .../Scripts/Slider/HorizontalResizeSlider.vue | 4 +- .../Scripts/View/Cards/CardListItem.vue | 4 +- .../TreeView/Bindings/TreeInputFilterEvent.ts | 10 - .../View/Tree/TreeView/Node/UseNodeState.ts | 4 +- .../Scripts/View/Tree/TreeView/TreeView.vue | 4 +- .../View/Tree/TreeView/UseCurrentTreeNodes.ts | 8 +- .../TreeView/UseNodeStateChangeAggregator.ts | 4 +- .../UseSelectedScriptNodeIds.ts | 8 +- .../TreeViewAdapter/UseTreeViewFilterEvent.ts | 6 +- .../Shared/Hooks/UseCollectionState.ts | 9 +- .../components/Shared/Icon/UseSvgLoader.ts | 4 +- .../components/Shared/Modal/ModalContent.vue | 4 +- .../components/Shared/SizeObserver.vue | 6 +- .../components/Shared/TooltipWrapper.vue | 12 +- .../View/Tree/TreeView/TreeView.spec.ts | 6 +- .../Context/State/Filter/UserFilter.spec.ts | 4 +- .../Scripts/View/TheScriptsView.spec.ts | 28 +- .../Bindings/TreeViewFilterEvent.spec.ts | 28 +- .../Tree/TreeView/Node/UseNodeState.spec.ts | 10 +- .../Tree/TreeView/UseCurrentTreeNodes.spec.ts | 8 +- .../UseTreeViewFilterEvent.spec.ts | 279 ++++++++++++++++++ .../shared/Stubs/FilterChangeDetailsStub.ts | 26 ++ .../shared/Stubs/UseCollectionStateStub.ts | 8 +- .../shared/Stubs/UseCurrentTreeNodesStub.ts | 4 +- 24 files changed, 377 insertions(+), 111 deletions(-) create mode 100644 tests/unit/presentation/components/Scripts/View/Tree/TreeViewAdapter/UseTreeViewFilterEvent.spec.ts diff --git a/src/presentation/components/Scripts/Slider/HorizontalResizeSlider.vue b/src/presentation/components/Scripts/Slider/HorizontalResizeSlider.vue index 197524c59..bedcb33b3 100644 --- a/src/presentation/components/Scripts/Slider/HorizontalResizeSlider.vue +++ b/src/presentation/components/Scripts/Slider/HorizontalResizeSlider.vue @@ -19,7 +19,7 @@