Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MazePlot wandb integration #140

Open
canrager opened this issue Mar 28, 2023 · 1 comment
Open

MazePlot wandb integration #140

canrager opened this issue Mar 28, 2023 · 1 comment
Labels
wandb anything related to weights & biases integration

Comments

@canrager
Copy link
Contributor

canrager commented Mar 28, 2023

I think the function should return figure and axes (i.e. use f, ax = plt.subplots() and ax.imshow()) this way the outputs can be passed to a wandb log call, or incorporated into another figure with subplots (ideally add a kwarg that directly accepts an axes object, in which case one doesn't need to create a new figure

Originally posted by @afspies in #108 (comment)

Alternatively: Add .to_wandb() function to MazePlot which returns the objects wandb log needs. @afspies which objects does wandb explicitly require for plotting?

@afspies
Copy link
Member

afspies commented Mar 28, 2023

wandb can be given a figure object (https://docs.wandb.ai/guides/track/log/plots#matplotlib-and-plotly-plots) or image array directly.

Indeed I think the correct behaviour is to have functions create figure objects unless an axis is passed via an optional kwarg.

If an axis is passed then this should be used directly (i.e. if one wants to have different subplots be filled in by plotting function calls)

@mivanit mivanit added the wandb anything related to weights & biases integration label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wandb anything related to weights & biases integration
Projects
None yet
Development

No branches or pull requests

3 participants