Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing dataset to train_model #194

Open
mivanit opened this issue Oct 1, 2023 · 0 comments
Open

allow passing dataset to train_model #194

mivanit opened this issue Oct 1, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mivanit
Copy link
Member

mivanit commented Oct 1, 2023

currently in the training notebook, we first create the dataset, and then load it again because we only pass the ConfigHolder to train_model. There should be an option to pass the dataset, and then we check the dataset config for correctness (or, if overridden, modify the ConfigHolder)
@mivanit mivanit added enhancement New feature or request good first issue Good for newcomers labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mivanit