Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradiction in signature of plot_topoplotseries #229

Closed
vladdez opened this issue Aug 15, 2024 · 3 comments
Closed

Contradiction in signature of plot_topoplotseries #229

vladdez opened this issue Aug 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@vladdez
Copy link
Collaborator

vladdez commented Aug 15, 2024

julia>     plot_topoplotseries(df; bin_num = 5)
ERROR: AssertionError: No positions found, did you forget to provide them via positions=XX, or labels=YY?

So position is args now, not kwargs?

@vladdez vladdez added the bug Something isn't working label Aug 15, 2024
@behinger
Copy link
Member

I vote no, because you can provide labels (via 10-20systrm) or positions. So positions can be optional.

But more once I'm back from Vacation

@vladdez
Copy link
Collaborator Author

vladdez commented Aug 15, 2024

okay, then we need to put some dummies instead of positions, right?

@behinger
Copy link
Member

behinger commented Sep 2, 2024

I dont understand - right now you can do:
plot_topoplots(data;positions=pos)
or
plot_topoplot(data;labels=labels)

Clearly related to #227 and we continue the discussion there as it is the same issue

@behinger behinger closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants