Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraft cloud image remove is inconsistent #1305

Open
craciunoiuc opened this issue Feb 27, 2024 · 1 comment
Open

kraft cloud image remove is inconsistent #1305

craciunoiuc opened this issue Feb 27, 2024 · 1 comment
Labels
kind/bug Something isn't working priority/medium Issue which is important, but KraftKit is usable without it also.

Comments

@craciunoiuc
Copy link
Member

Describe the bug

The command kraft cloud image remove has shown to be buggy and not consistent with what it should actually do.

There are currently two bugs.

1. Now Fully Broken

 kraft cloud img rm http-python312-flask30
 i  removing http-python312-flask30
 W  http-python312-flask30 not found. This is expected if you have already removed it.
➜  webinstall git:(staging) ✗ kraft cloud img rm http-python312-flask30:latest
 i  removing http-python312-flask30:latest
 W  http-python312-flask30:latest not found. This is expected if you have already removed it.
➜  webinstall git:(staging) ✗ kraft cloud img rm cezar.unikraft.io/http-python312-flask30:latest
 i  removing http-python312-flask30:latest
 W  http-python312-flask30:latest not found. This is expected if you have already removed it.

These three cases should all work, but somehow do not delete the image anymore.

The warning displayed was introduced in e0f4015 as a response to the bug detailed in 2. After that was introduced, somehow images were no longer removed at all.

As it can be seen in e0f4015 the actual deletion happens in the go-sdk not kraftkit.

2. Then Partially Broken

Before these "fixes" were introduced it had an inconsistency problem.

Images were correctly deleted, and usually (50/50) disappeared and no longer showed up in kraft cloud img ls. For the rest of the time they still showed up and trying to delete them again resulted in a nasty NOT_FOUND error from harbor.

This was not a harbor issue I think, as the artifacts no longer showed up in the dashboard and I also ran the garbage collector on them. This means that the no-update happened somewhere between Harbor<->Platform. Those images actually disappeared from the list after 2-3 minutes, but that is of course too much.

The fix that caused 1. was done to hide the error and print a prettier message to let people know that there's nothing to worry about.

Steps to reproduce

  1. Use latest kraftkit
  2. push/deploy an image
  3. kraft cloud img rm it

Expected behavior

No response

Which architectures were you using or does this bug affect?

No response

Which operating system were you using or does this bug affect?

No response

Relevant log output

No response

@craciunoiuc craciunoiuc added the kind/bug Something isn't working label Feb 27, 2024
@craciunoiuc
Copy link
Member Author

Update: This happens because of how the cleanup cycle operates currently. It is not a bug in KraftKit. Will leave the Issue open to track it.

@craciunoiuc craciunoiuc added the priority/medium Issue which is important, but KraftKit is usable without it also. label Feb 29, 2024
@craciunoiuc craciunoiuc moved this from Backlog to Ready in KraftKit Issue Priority List Feb 29, 2024
@antoineco antoineco removed their assignment Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/medium Issue which is important, but KraftKit is usable without it also.
Projects
Status: Ready
Development

No branches or pull requests

2 participants