Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraft progress bar for pull operation stays at 0% then jumps to 100% at end (ie, shows no progress) #1380

Open
felipehuici opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels
kind/bug Something isn't working priority/none Nice to have issues/features that do not have requests/complaints right now.

Comments

@felipehuici
Copy link
Member

Describe the bug

kraft progress bar for pull operation stays at 0% then jumps to 100% at end (ie, shows no progress)

Steps to reproduce

Any kraft run cmd (see relevant log output for example)

Expected behavior

Progress bar shows different percentage as pull operation progresses

Which architectures were you using or does this bug affect?

x86_64

Which operating system were you using or does this bug affect?

macOS

Relevant log output

% kraft run --rm -p 8080:8080 --plat qemu --arch x86_64 -M 256M
 W  using hardware emulation
 i  using arch=x86_64 plat=qemu
[+] pulling unikraft.org/php:8.2 (qemu/x86_64) •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 0% [56s]
@felipehuici felipehuici added kind/bug Something isn't working priority/low Nice to have issues thatare not urgent, but can be nagging. labels Mar 6, 2024
@craciunoiuc
Copy link
Member

This is a bit harder to do, as the pull detects if it's an OCI archive or a regular git repos/links after the progress bar was provided.

This is relevant because for github repos/links it works so it's not easy to disable progress only OCI

We'll do this later

@craciunoiuc craciunoiuc added priority/none Nice to have issues/features that do not have requests/complaints right now. and removed priority/low Nice to have issues thatare not urgent, but can be nagging. labels Aug 29, 2024
@craciunoiuc
Copy link
Member

Did an extensive look, this is not possible for OCI and HTTPS cloning, it will only partially work for SSH cloning

The fix here should be to remove the progress bar altogether for pulling unfortunately

@craciunoiuc craciunoiuc self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/none Nice to have issues/features that do not have requests/complaints right now.
Projects
None yet
Development

No branches or pull requests

2 participants