Resolve build errors and update integration guide in README.md #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__phys_addr has already been replaced with with __paddr_t with this commit:unikraft/unikraft@0043e56 , __phys_addr was not defined anywhere and it was causing build erros.
Improved integration guide is needed until this merges into main branch, specially for new contributers.
SikkiLadho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As a part Unikraft Weekly Hackathon, I have removed build errors from plat-raspi(spagani-devel) branch and updated the README.md for improved integration guide.
Precisely, I have replaced
__phys_addrwith__paddr_tin io.c.__phys_addris an obsolete/undefined type after this commit by @marcrittinghaus.Another change I made was replacing
size_twith__sz, size_t was also not defined(or stddef.h was not included.), so I replacedsize_twith__szin memory.c.__szis a type, equivalent tosize_t.Sikkiladho(Mushahid Hussain)