Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remap through official can cause issues with parent classes having same field #18

Open
wagyourtail opened this issue Mar 30, 2023 · 1 comment
Open

remap through official can cause issues with parent classes having same field #18

wagyourtail opened this issue Mar 30, 2023 · 1 comment
Labels
bug Something isn't working priority: low fixable with a minor change to build.gradle

Comments

@wagyourtail
Copy link
Collaborator

wagyourtail commented Mar 30, 2023 •
edited
Loading

mainly an issue with forge patches
see,
(mojmap warning)



patch by changing getfield to get on actual class instead of inherited class, requires resolving parents at jarmod time
@wagyourtail wagyourtail added bug Something isn't working priority: medium breaks something in dev 🤦 forge priority: low fixable with a minor change to build.gradle and removed priority: medium breaks something in dev 🤦 forge labels Mar 30, 2023
@wagyourtail
Copy link
Collaborator Author

wagyourtail commented Mar 30, 2023 •
edited
Loading

workaround: include a mapping type with types (anything that isn't srg/mcp) and don't enable ignoreFieldDesc

needs further testing

@wagyourtail wagyourtail changed the title remap to official can cause issues with parent classes having same field remap through official can cause issues with parent classes having same field Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: low fixable with a minor change to build.gradle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wagyourtail