-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
help the developpers to detect that there is 2 reducer with same name/prefix #79
Comments
Yes it seems good to me and useful to avoid problems to avoid name collisions |
@bpetetot do you know how to handle dev/prod build from a library perspective ? |
In ReactJS, they build 2 differents bundles: 'use strict';
if (process.env.NODE_ENV === 'production') {
module.exports = require('./cjs/react.production.min.js');
} else {
module.exports = require('./cjs/react.development.js');
} |
Hmm ok, so we have to build 2 times the libs:
And add this index.js manually |
I think you can directly build dev and prod bundles through the rollup config. So you will not have to call 2 times the |
I move the lib to microbundle |
Only in development builds:
(name, prefix)
[k-redux-factory] You combined two reducers with same name and prefix, we think this is a bug. You should look at 'prefix' option to create your reducer(s)!
@bpetetot are you ok ?
This is related to #73 that is coming back on a regular basis
The text was updated successfully, but these errors were encountered: