Problem with Gateway in Python3.X

[ptitloup]

File : django_cas/views.py in _service_url L.51
Problem : can only concatenate list (not "generator") to list

Fixed by :

• L.43 query_list = query_dict.items()
  +L.43 query_list = list(query_dict.items())

[agrausem]

We can replace this part of code (l.42 → l.49) :

query_list = query_dict.items()
 #remove duplicate params
 for item in query_list:
      for index, item2 in enumerate(gateway_params):
          if item[0] == item2[0]:
              gateway_params.pop(index)
 extra_params = gateway_params + query_list

by this one :

extra_params = set(gateway_params).union(set(query_dict.items()))

I'll make the changes in a dedicated branch and let you test the fix.
Thanks for the report

[ptitloup]

Thanks for this better fix. It works perfectly. Have a good day Nicolas Le 16/05/2018 21:21, Arnaud Grausem a écrit :

…

We can replace this part of code (l.42 → l.49) : |query_list = query_dict.items() #remove duplicate params for item in query_list: for index, item2 in enumerate(gateway_params): if item[0] == item2[0]: gateway_params.pop(index) extra_params = gateway_params + query_list | by this one : |extra_params = set(gateway_params).union(set(query_dict.items())) | I'll make the changes in a dedicated branch and let you test the fix. Thanks for the report — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEbNAjboCbnEsROnnbgsaqNVZREm0p46ks5tzHw9gaJpZM4UBYQb>. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/unistra/django-cas","title":"unistra/django-cas","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in ***@***.*** in #6: We can replace this part of code (l.42 → l.49) :\r\n \r\n query_list = query_dict.items()\r\n #remove duplicate params\r\n for item in query_list:\r\n for index, item2 in enumerate(gateway_params):\r\n if item[0] == item2[0]:\r\n gateway_params.pop(index)\r\n extra_params = gateway_params + query_list\r\n\r\nby this one :\r\n\r\n extra_params = set(gateway_params).union(set(query_dict.items()))\r\n\r\nI'll make the changes in a dedicated branch and let you test the fix.\r\nThanks for the report"}],"action":{"name":"View ***@***.******@***.***":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [unistra/django-cas] Problem with Gateway in Python3.X (#6)","sections":[{"text":"","activityTitle":"**Arnaud ***@***.***","facts":[]}],"potentialAction":[{"name":"Add a ***@***.******@***.******@***.***":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"unistra/django-cas\",\"issueId\":6,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close ***@***.******@***.***":"OpenUri","name":"View on ***@***.***":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335905819}"}],"themeColor":"26292E"}

-- Université de Lille *Nicolas CAN* Ingénieur développement et intégration d'application Direction des Systèmes d'information [email protected] <mailto:[email protected]> *|* www.univ-lille.fr <http://www.univ-lille.fr> bat. A03 59655 Villeneuve d´Ascq Cedex T.+33 (0)3 20 33 60 73