verify_certs option not applied in upload_document

[cso-sekkop]

As says the title, when setting verify_certs to False in the initialisation, upload_document() still verify SSL Certs.

        with open(filepath, 'rb') as fhandler:
            response = requests.post(
                url=self._set_method('Document'),
                headers={
                    'Session-Token': self.session.headers['Session-Token'],
                    'App-Token': self.session.headers['App-Token']
                },
                files={
                    'uploadManifest': (
                        None,
                        _UPLOAD_MANIFEST.format(name=name, filename=os.path.basename(filepath)),
                        'application/json'
                    ),
                    'filename[0]': (filepath, fhandler)
                }
            )

should be:

        with open(filepath, 'rb') as fhandler:
            response = requests.post(
                url=self._set_method('Document'),
                headers={
                    'Session-Token': self.session.headers['Session-Token'],
                    'App-Token': self.session.headers['App-Token']
                },
                files={
                    'uploadManifest': (
                        None,
                        _UPLOAD_MANIFEST.format(name=name, filename=os.path.basename(filepath)),
                        'application/json'
                    ),
                    'filename[0]': (filepath, fhandler)
                },
                verify=self.session.verify
            )

[fmenabe]

Well in fact, the session should be used when making the post instead of using requests directly (response = self.session.post). I don't remember if there was a reason for that (if using the session, headers should not have to be redefined also).

Anyway, will try to find some time to correct that.

[cso-sekkop]

I made some test to patch it. When I used self.session instead of requests, the "Content-Type" header and the body was acting weird.
The Content-Type was stuck in "application/json" even with "file=..." used.
Forcing "Content-Type":"formdata" was not working either, their was no "bondary=" present in the request.

My theory is that the content-type of the sessions is manually set somewhere and it mess with requests function.
So using "requests" seems to be the easiest fix.