Add extra check to prevent bundler writes where we have nothing set

unitoftime · Mar 6, 2025 · 7d499c2 · 7d499c2
1 parent 8a8920a
commit 7d499c2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/bundle.go b/bundle.go
@@ -69,5 +69,8 @@ func (bun *Bundler) Remove(compId CompId) {
 // }
 
 func (b *Bundler) Write(world *World, id Id) {
+	if b.archMask == blankArchMask {
+		return // If the bundler is empty, just dont do anything
+	}
 	world.writeBundler(id, b)
 }
diff --git a/command.go b/command.go
@@ -39,11 +39,17 @@ func (c *singleCmd) apply(world *World) {
 			world.cmd.preWrite(EntityCommand{c})
 		}
 		c.bundler.Write(world, c.id) // TODO: This could probably use a Spawn function which would be faster
+		// if world.cmd.postWrite != nil {
+		// 	world.cmd.postWrite(c.id)
+		// }
 	case CmdTypeWrite:
 		if world.cmd.preWrite != nil {
 			world.cmd.preWrite(EntityCommand{c})
 		}
 		c.bundler.Write(world, c.id)
+		// if world.cmd.postWrite != nil {
+		// 	world.cmd.postWrite(c.id)
+		// }
 	case CmdTypeTrigger:
 		world.Trigger(c.event, c.id)
 	case CmdTypeDelete:
@@ -70,6 +76,7 @@ type EntityCommand struct {
 
 func (e EntityCommand) Cancel() {
 	e.cmd.Type = CmdTypeNone
+	e.cmd.id = InvalidEntity
 }
 
 // Removes the supplied component type from this entity command.