Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse multiple cookies with same name #51

Open
pi0 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #55
Open

Parse multiple cookies with same name #51

pi0 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #55
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Sep 3, 2024 •
edited
Loading

Describe the feature

Background: jshttp/cookie#60 (found it in an issue reported by @atinux)

Incoming cookie value can have the same name repeated and we pick the first.

We can allow them in two possible ways:

  • { sameKeysPolicy: 'last' } as proposed in Reading duplicated cookies jshttp/cookie#60
  • { multiple: true } that makes return type Record<string, string | string[]>
  • { multiple: true } that concatinates multiple values with ,
@pi0 pi0 added the enhancement New feature or request label Sep 3, 2024
@jpsc jpsc linked a pull request Oct 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(options): add allowMultiple to options jpsc/cookie-es
1 participant
@pi0