Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate TSX with Solid factory #325

Closed
1 task done
SokuRitszZ opened this issue Oct 3, 2023 · 4 comments
Closed
1 task done

Generate TSX with Solid factory #325

SokuRitszZ opened this issue Oct 3, 2023 · 4 comments

Comments

@SokuRitszZ
Copy link

Describe the feature

I'm trying to build my package what is using solid-js.

image

but the result is:

image

Additional information

  • Would you be willing to help implement this feature?
@pi0
Copy link
Member

pi0 commented Oct 4, 2023

Hi. You can use TSConfig to change jsxFactory settings generating solid output. If you can share you repo i can help better :)

@pi0 pi0 changed the title Support build JSX/TSX file via solid-js Generate TSX with Solid factory Oct 4, 2023
@SokuRitszZ
Copy link
Author

Hi. You can use TSConfig to change jsxFactory settings generating solid output. If you can share you repo i can help better :)

I tried to set jsxFactory: createComponent & add /** @jsx createComponent */ at the begining of jsx file, there is no error but it generated code that
image
it seems to be very similar with how React.createElement create dom. It should be the result like that
image

Here is the repo of my code: https://github.com/SokuRitszZ/monorepo-test, and the path is packages/reversi-solid-renderer. Thanks for your help!

I apologize for my poor English and open source experience :(

@17359898647
Copy link

17359898647 commented Jul 2, 2024

Have you solved it yet?

@pi0
Copy link
Member

pi0 commented Dec 27, 2024

A nice reference by @crutchcorn here for anyone wondering how: cmgriffing/shiki-magic-move#3

(closing to track from #398 as docs)

@pi0 pi0 closed this as completed Dec 27, 2024
@pi0 pi0 mentioned this issue Dec 27, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants