feature(provider): Rate limiting #15583
Open
+1,438
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
reviewed
Feb 28, 2025
| try { | ||
| // Create a key that combines IP with contract address or method to provide granular rate limiting | ||
| // This is a more stable identifier than just IP alone, as recommended by Cloudflare | ||
| const rateKey = contractAddress |
There was a problem hiding this comment.
In our case I think it will be almost exclusively POST though,,, but not a a big deal!
julien51
reviewed
Feb 28, 2025
provider/src/handler.ts
Outdated
Comment on lines
231
to
250
| if (!isRateLimitAllowed) { | ||
| return Response.json( | ||
| { | ||
| id: body.id || 42, | ||
| jsonrpc: '2.0', | ||
| error: { | ||
| code: -32005, | ||
| message: 'Rate limit exceeded', | ||
| }, | ||
| }, | ||
| { | ||
| status: 429, | ||
| headers: { | ||
| ...headers, | ||
| 'Retry-After': '60', // Suggest retry after 60 seconds | ||
| }, | ||
| } | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
ok for now, in order to not break anything, let;'s not actaully block things but add a log message so we cna see how that would perform. Once we have it running for 10 days or more we can go check at what would have actually been blocked and check that it works as expected. wdyt?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
julien51
reviewed
Feb 28, 2025
provider/src/handler.ts
Outdated
Comment on lines
231
to
233
| console.log( | ||
| `RATE_LIMIT_WOULD_BLOCK: IP=${getClientIP(request)}, Method=${body.method}, Contract=${contractAddress || 'none'}, ID=${body.id || 'none'}` | ||
| ) |
There was a problem hiding this comment.
Actually, can we log the full body as well? This could be useful to debug more.
There was a problem hiding this comment.
(insead of just the ID which is not very useful!)
julien51
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces rate limiting, and a multi-tier lock address caching system for our
providerto improve performance, reduce blockchain calls, and prevent abuse.Rate Limiting
Lock Address Caching
These changes improve response times, reduce RPC overhead, and ensure fair resource usage.
Issues
Fixes #15559
Refs #15559
Checklist: