From ec18834260a36e5b440b8508bd54813e525176d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Laban?= Date: Thu, 7 Feb 2019 16:11:35 -0500 Subject: [PATCH 1/2] Add string.Contains(char) as excluded method for vs15.9 --- src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs | 2 +- src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs b/src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs index 6efaa367564c..a11b1ec159e4 100644 --- a/src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs +++ b/src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs @@ -467,7 +467,7 @@ IEnumerable DoLookupAllMembers () var bf = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance; foreach (var pi in UnderlyingType.GetProperties (bf)) { - if (pi.Name.Contains ('.')) // exclude explicit interface implementations. + if (pi.Name.Contains (".")) // exclude explicit interface implementations. continue; if (pi.CanRead && (pi.CanWrite || IsCollectionType (pi.PropertyType) || typeof (IXmlSerializable).IsAssignableFrom (pi.PropertyType)) && pi.GetIndexParameters ().Length == 0) yield return new XamlMember (pi, SchemaContext); diff --git a/src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs b/src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs index 7012173373f5..fa14f64085f6 100644 --- a/src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs +++ b/src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs @@ -76,6 +76,7 @@ public Container(Compilation compilation, MonoNotSupportedAPIAnalyzer owner) "IndexOfAny", "Join", "StartsWith", + "Contains", }, Validation = new Func( m => m.Parameters.FirstOrDefault()?.Type == _charSymbol From 7acb7d9d0c5d55d35c8f2813196d43f40ce772ee Mon Sep 17 00:00:00 2001 From: "mathieu.fillion@nventive.com" Date: Fri, 8 Mar 2019 11:18:08 -0500 Subject: [PATCH 2/2] Bump minor version --- gitversion.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitversion.yml b/gitversion.yml index 6a8fc5dd28f6..606458162f2a 100644 --- a/gitversion.yml +++ b/gitversion.yml @@ -1,6 +1,6 @@ assembly-versioning-scheme: MajorMinorPatch mode: ContinuousDeployment -next-version: 1.43.0 +next-version: 1.43.1 continuous-delivery-fallback-tag: "" branches: master: