Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][WASM] CommandBar is clipped when secondary commands is opened, and the popup is not dismissed when a pointer clicks outside it #13147

Open
ramezgerges opened this issue Aug 7, 2023 · 2 comments
Open

[Android][WASM] CommandBar is clipped when secondary commands is opened, and the popup is not dismissed when a pointer clicks outside it #13147

ramezgerges opened this issue Aug 7, 2023 · 2 comments
Assignees
@MartinZikmund
Labels
area/commandbar Categorizes an issue or PR as relevant to CommandBar difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/regression Something was working, now it isn't platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@ramezgerges
Copy link
Contributor

ramezgerges commented Aug 7, 2023 •
edited
Loading

Current behavior

2023-08-07.13-50-32.mp4
2023-08-07.15-02-31.mp4

Notice that on Android, the secondary commands window can't be dismissed except by clicking on one of the choices. Clicking outside doesn't work.

Expected behavior

The bar shouldn't be clipped.

How to reproduce it (as minimally and precisely as possible)

Check out the repro at #1509

Workaround

Resize the viewport.

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@ramezgerges ramezgerges added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 7, 2023
@Youssef1313 Youssef1313 added the area/commandbar Categorizes an issue or PR as relevant to CommandBar label Aug 7, 2023
@ramezgerges ramezgerges changed the title [WASM] CommandBar is clipped when secondary commands is opened [Android][WASM] CommandBar is clipped when secondary commands is opened Aug 7, 2023
@ramezgerges ramezgerges self-assigned this Aug 8, 2023
@ramezgerges ramezgerges changed the title [Android][WASM] CommandBar is clipped when secondary commands is opened [Android][WASM] CommandBar is clipped when secondary commands is opened, and the popup is not dismissed when a pointer clicks outside it Aug 11, 2023
@ramezgerges ramezgerges mentioned this issue Aug 11, 2023
Merged
6 tasks
@ramezgerges
Copy link
Contributor Author

@MartinZikmund This seems to be broken by #12597. CommandBar is implemented really weirdly, so the numbers for measure/arrange (DesizedSize, etc) don't really change when the CommandBar is expanded, so the render invalidation is not complete. I'm not sure exactly what condition needs to be additionally checked for this to work.

@jeromelaban jeromelaban added kind/regression Something was working, now it isn't and removed kind/bug Something isn't working labels Aug 14, 2023
@MartinZikmund MartinZikmund self-assigned this Sep 5, 2023
@MartinZikmund MartinZikmund added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 20, 2023
@iurycarlos iurycarlos mentioned this issue Oct 2, 2023
Open
@ramezgerges ramezgerges removed their assignment Jun 5, 2024
@Youssef1313
Copy link
Member

Youssef1313 commented Sep 21, 2024 •
edited
Loading

For Android, we'll need to verify after #18261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinZikmund MartinZikmund

Labels
area/commandbar Categorizes an issue or PR as relevant to CommandBar difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/regression Something was working, now it isn't platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MartinZikmund @jeromelaban @Youssef1313 @ramezgerges