Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gallery][WASM][UI Components -TextBox] Misalignment of Clear Button with Cursor When Switching Between Textboxes #1458

Open
2 of 5 tasks
jhanvi03 opened this issue Aug 21, 2024 · 16 comments · May be fixed by unoplatform/uno#18522
Open
2 of 5 tasks

[Gallery][WASM][UI Components -TextBox] Misalignment of Clear Button with Cursor When Switching Between Textboxes #1458

jhanvi03 opened this issue Aug 21, 2024 · 16 comments · May be fixed by unoplatform/uno#18522
Assignees
@ajpinedam
Labels
kind/bug Something isn't working

Comments

@jhanvi03
Copy link

jhanvi03 commented Aug 21, 2024 •
edited
Loading

Current behavior

When switching from one textbox to another, the cross sign (clear button) for removing text does not align with the cursor

Screen.Recording.2024-08-21.at.11.34.07.AM.mov

Expected behavior

The cross sign (clear button) should be consistently aligned with the cursor when switching between textboxes

How to reproduce it (as minimally and precisely as possible)

  1. Open Galley canary WASM
  2. From the side Menu expand UI components
  3. From UI components click on TextBox
  4. Enter text in one textbox
  5. Enter text in another textbox
  6. switch between 2 textbox and observe the clear sign

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • MacOS

Anything else we need to know?

Could be related to unoplatform/uno#17914 , unoplatform/uno#17633
@jhanvi03 jhanvi03 added the kind/bug Something isn't working label Aug 21, 2024
@agneszitte
Copy link
Contributor

@eriklimakc can you take a look and leave more info please

@eriklimakc
Copy link
Contributor

From a quick test using an newly created Uno app:

That's wasm only. Apparently the control is not changing to the "Focused" VisualState when it is clicked.

This is reproducible on both the "FilledTextBoxStyle" and the "OutlinedTextBoxStyle". But also with PasswordBox, so I don't think this is a bug brought with the Header/Placeholder changes.

cc @agneszitte @kazo0

@eriklimakc
Copy link
Contributor

This issue is also reproducible using <UnoThemesVersion>5.0.13</UnoThemesVersion>. Version prior to the Header+Placeholder changes. Could it be related to unoplatform/uno#17914?

cc @dr1rrb @Xiaoy312 @kazo0

@eriklimakc
Copy link
Contributor

It's reproducible on fluent from blank template: unoplatform/uno#18040

@agneszitte agneszitte assigned Youssef1313 and unassigned eriklimakc Aug 27, 2024
@agneszitte
Copy link
Contributor

agneszitte commented Aug 27, 2024 •
edited
Loading

@Youssef1313 is unoplatform/uno#18042 will completely fix this issue, please?

@Youssef1313
Copy link
Member

Yes it should, I think.

@agneszitte agneszitte assigned jhanvi03 and unassigned Youssef1313 Aug 28, 2024
@agneszitte
Copy link
Contributor

@jhanvi03 can you retest this issue with latest Gallery canary build to verify if it is fixed please

@jhanvi03
Copy link
Author

jhanvi03 commented Sep 4, 2024

Tested with latest canary build and I am still able to reproduce.

Screen.Recording.2024-09-04.at.2.12.24.PM.mov

@Youssef1313
Copy link
Member

Latest available Uno.Sdk doesn't include the fix yet. We need unoplatform/uno.templates#941 first

@agneszitte agneszitte removed their assignment Sep 4, 2024
@agneszitte
Copy link
Contributor

@Youssef1313 if you can update @jhanvi03 when it will be ready for QA again for this issue, it will be appreciated please

@agneszitte agneszitte assigned jhanvi03 and unassigned Youssef1313 and eriklimakc Sep 5, 2024
@Youssef1313
Copy link
Member

It should be ready for testing again

@kazo0
Copy link
Collaborator

kazo0 commented Sep 9, 2024 •
edited
Loading

FYI @jhanvi03 I think you should be able to test this now, at least once there is a working canary :)

@jhanvi03
Copy link
Author

jhanvi03 commented Sep 9, 2024 •
edited
Loading

The issue is resolved on Mac WASM but persists on iOS. On iOS, when moving the cursor from one textbox to another:
-The 'Cross' icon does not appear.
-Instead of placing the cursor at the end of the text, all the text gets selected. After deselecting, the 'Cross' icon still does not appear.

MAC WASM: Test Pass
Version:
Package Referenced version Updated version
Uno.Core.Extensions.Compatibility 4.0.1 4.1.1
Uno.Core.Extensions.Disposables 4.0.1 4.1.1
Uno.Sdk 5.3.96 5.4.0-dev.236

Package Referenced version Updated version
Uno.Core.Extensions.Compatibility 4.0.1 4.1.1
Uno.Core.Extensions.Disposables 4.0.1 4.1.1
Uno.Sdk 5.3.96 5.4.0-dev.236
Screen.Recording.2024-09-09.at.9.56.14.AM.mov

iOS: Test Fail
Version: 1.6.0(2409061451.1778)

RPReplay_Final1725571807.2.MP4

@agneszitte agneszitte assigned Youssef1313 and unassigned jhanvi03 Sep 12, 2024
@agneszitte
Copy link
Contributor

agneszitte commented Sep 12, 2024 •
edited
Loading

The issue is resolved on Mac WASM but persists on iOS

@Youssef1313 I will let you take a look as @jhanvi03 is still able to reproduce on iOS please

@Youssef1313 Youssef1313 removed their assignment Sep 16, 2024
@Youssef1313
Copy link
Member

@ajpinedam Would you be able to help with the iOS part of this issue?

@ajpinedam
Copy link
Contributor

@ajpinedam Would you be able to help with the iOS part of this issue?

Yes, sure I can look into it. (@Youssef1313 ).

Thanks @agneszitte for assigning the issue to me :)

@ajpinedam ajpinedam linked a pull request Oct 21, 2024 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajpinedam ajpinedam

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iOS): textbox selection clear button ajpinedam/uno
6 participants
@ajpinedam @kazo0 @agneszitte @Youssef1313 @eriklimakc @jhanvi03