Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate generated GlobalStaticResources class #18616

Open
mikernet opened this issue Oct 29, 2024 · 1 comment
Open

Annotate generated GlobalStaticResources class #18616

mikernet opened this issue Oct 29, 2024 · 1 comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request

Comments

@mikernet
Copy link
Contributor

mikernet commented Oct 29, 2024 •
edited
Loading

What would you like to be added

Please annotate the generated GlobalStaticResources class with either [GeneratedCode] and/or [EditorBrowsableAttribute(Never)] so it doesn't pollute library documentation generated by docfx :)

Why is this needed

image

For which platform

No response

Anything else we need to know?

No response
@mikernet mikernet added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Oct 29, 2024
@jeromelaban
Copy link
Member

jeromelaban commented Nov 4, 2024 •
edited
Loading

Note for contributors

Such a change should included here:

uno/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs

Lines 688 to 689 in 94b1943

using (writer.BlockInvariant("public sealed partial class GlobalStaticResources"))
{

@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikernet @jeromelaban