Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(droid): TabView header not showing #18677

Merged
merged 7 commits into from
Nov 15, 2024
Merged

fix(droid): TabView header not showing #18677

merged 7 commits into from
Nov 15, 2024

Conversation

ajpinedam
Copy link
Contributor

GitHub Issue (If applicable): closes https://github.com/unoplatform/ziidms-private/issues/31

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

TabView header not showing on Android.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Nov 3, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from c7d5091 to dd1e3d2 Compare November 4, 2024 17:44
@ajpinedam ajpinedam marked this pull request as ready for review November 4, 2024 17:44
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from 332e85a to 83d51be Compare November 5, 2024 03:41
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from 83d51be to 136fd19 Compare November 5, 2024 14:06
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@jeromelaban
Copy link
Member

@ajpinedam https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=146283&view=logs&j=a54adc20-f97a-5e02-19e8-cc33821dfc3e&t=50c2e5c6-4861-5ee5-b4ae-73b4c495ee2b&l=115

@ajpinedam
Copy link
Contributor Author

/azp run

@ajpinedam https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=146283&view=logs&j=a54adc20-f97a-5e02-19e8-cc33821dfc3e&t=50c2e5c6-4861-5ee5-b4ae-73b4c495ee2b&l=115

Thanks! Fixing it now...

@azure-pipelines Azure Pipelines
Copy link

Command 'run

' is not supported by Azure Pipelines.


Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@jeromelaban
Copy link
Member

@ajpinedam could you take a look at the build errors: https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=146383&view=logs&j=50eac85d-e4f1-52a9-e299-c16e8a5f721f&t=f3688660-31ca-56fb-ec9e-b4e953c28722&l=142?

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from 09069bb to 832abe6 Compare November 8, 2024 18:40
@ajpinedam
Copy link
Contributor Author

@ajpinedam could you take a look at the build errors: https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=146383&view=logs&j=50eac85d-e4f1-52a9-e299-c16e8a5f721f&t=f3688660-31ca-56fb-ec9e-b4e953c28722&l=142?

Fixed. It was an indentation problem.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from 832abe6 to aff2b96 Compare November 12, 2024 01:16
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from aff2b96 to 439c11a Compare November 14, 2024 21:44
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@ajpinedam ajpinedam force-pushed the fix/tabview.droid.header branch from f1248a0 to d1ca282 Compare November 15, 2024 06:10
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18677/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18677/index.html

@MartinZikmund MartinZikmund merged commit ce498ef into unoplatform:master Nov 15, 2024
110 checks passed
@ajpinedam ajpinedam deleted the fix/tabview.droid.header branch November 15, 2024 15:14
@ajpinedam
Copy link
Contributor Author

@jeromelaban are we backporting this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees

@ajpinedam ajpinedam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajpinedam @unodevops @jeromelaban @MartinZikmund