Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uno.Sdk adds ~1mb of unnecessary image assets to library project packages #18678

Open
mikernet opened this issue Nov 3, 2024 · 1 comment
Open
Assignees
Labels
area/external Categorizes an issue or PR as being external to the Uno

Comments

@mikernet
Copy link
Contributor

mikernet commented Nov 3, 2024

Current behavior

Example of some of the assets that get packed into a nuget package that uses Uno.SDK:

image

Expected behavior

The content and contentFiles folders should not be packed.

How to reproduce it (as minimally and precisely as possible)

Create a new Uno library project that uses Uno.Sdk and add a ContentDialog to it. Build and pack.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@mikernet mikernet added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Nov 3, 2024
@MartinZikmund MartinZikmund added difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Nov 4, 2024
@mikernet
Copy link
Contributor Author

mikernet commented Nov 4, 2024

I will also note that this causes builds to fail with those libraries added to a project, since now there can be multiple conflicting files in the output with the same name.

@jeromelaban jeromelaban self-assigned this Nov 21, 2024
@jeromelaban jeromelaban added area/external Categorizes an issue or PR as being external to the Uno and removed kind/bug Something isn't working difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/external Categorizes an issue or PR as being external to the Uno
Projects
None yet
Development

No branches or pull requests

3 participants