fix(xamlreader): add proper support for markup-extension parsing #19185
+670
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
added
the
do-not-merge/work-in-progress
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19185/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19185/index.html |
|
|
Xiaoy312
force-pushed
the
dev/xygu/20250109/xamlreader-markup-support
branch
from
5c987de to
c13dc02
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19185/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19185/index.html |
|
|
|
The build 151666 has failed on Uno.UI - CI. just retrying for now |
|
The build 151666 found UI Test snapshots differences: Details
|
jeromelaban
reviewed
Jan 13, 2025
| { | ||
| var created = Activator.CreateInstance(classType); | ||
| TrySetContextualProperties(created, control); | ||
|
|
||
| return created; | ||
| } | ||
|
|
||
| var type = TypeResolver.FindType(control.Type); | ||
| #if false |
There was a problem hiding this comment.
Why is this disabled? Is it only for the comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #3399
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
-Extensionsuffix can be optionally omitted.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.