Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devSrv): Do not fail connection if a client processor fails (backport #19209) #19320

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 24, 2025

closes https://github.com/unoplatform/uno.hotdesign/issues/3136

Bugfix

Do not fail connection if a client processor initialization fails

What is the current behavior?

If a client processor fails (like HR client if not properly configured), then connection to the dev-server is not initialized properly.

What is the new behavior?

  • We are still listening for incoming frames if a client processor initialization fails.
  • HR client processor init does not crash if config is invalid.

PR Checklist


This is an automatic backport of pull request #19209 done by [Mergify](https://mergify.com).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19320/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19320/index.html

@nventive-devops
Copy link
Contributor

The build 153071 did not find any UI Test snapshots differences.

@jeromelaban jeromelaban merged commit 9773d00 into release/stable/5.6 Jan 24, 2025
113 of 114 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.6/pr-19209 branch January 24, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants