Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Addressing the limitations for [RTL] layouts out of the box #421

Closed
2 tasks done
omar-labana opened this issue Mar 21, 2024 · 2 comments
Closed
2 tasks done

Comments

@omar-labana
Copy link

Describe the feature

I'm building a couple of multilingual projects that require some reactive layout direction and most of the time to keep things localized I find myself replacing many of the classes like pl- & pr- with inline padding ps-. Also, some of the components like <Carousel> will be completely unusable on right-to-left layouts and it would scroll in the other direction(with slides being replaced with whitespace) despite using the radix-ui config provider, has anyone been through the same issue? would it be acceptable to submit a pr covering these challenges?

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@sadeghbarati
Copy link
Collaborator

We have PR #379 (change directional properties to logical properties)

The reason we hold it, we must see what other's opinions are

Also, you are right that Carousel does not respect radix-vue ConfigProvider dir

@sadeghbarati
Copy link
Collaborator

Let's track it here

#357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants