-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to change password from edit profile form #904
Comments
hey @mehreeee I think there used to be a |
Support for this is in place both backend and frontend. The only limitation is here. I think this can't stop designers from working on the issue. Let's just make everything ready. |
Yeah I understand what you mean, but it's also important to consider that parents or guardians may set up accounts for their children, and providing the ability to change passwords can give them a sense of ownership and security over their accounts. |
Hi @srish @coderatomy Here is a mockup of what I am proposing. I've incorporated a settings button on the side panel to address this issue. When clicked, it unveils a panel allowing users to monitor the number of devices logged into the same account. For instance, if a child has multiple iPads or tablets, parents can easily keep tabs. Additionally, if there's a need to change the password, or update a phone number or email, this feature handles it seamlessly. Keep in mind, this is just a mockup, so other elements can be included or removed as needed. |
Yeah! This looks good. Nice work @mehreeee. Just one thing. Will this mean that will this mean that editting profile will be moved to here? |
Yeah that is what I’m suggesting. Since we’re using Reddit’s model that allows users to remain anonymous to an extent, I would have suggested that if we click on the profile avatar, Users should only be able to change their profile picture. |
Yes, #904 (comment) makes sense. Some minor suggestions: Instead of "new password" say "change password". Beneath current password add a text "Forgot Password?" and link it to the reset password route. |
Nice. Taking over |
Hi @srish @coderatomy this is what I came up with. The forgot password text is a clickable link to reset the password The "Retype New Password" field should pop up when the "Change Password" field is selected. |
this is a nice design, i like the fact that user can retype their password for confirmation |
Thank you @Boluwatifey1 |
I and @JulietMadu made a similar design for issue #837 but it was closed because they did not want user to be able to edit their profile picture ,we also made a change password field but the retype password field is actually a better idea |
Great job @mehreeee, I love it, but some questions:
|
Hi @yokwejuste I made changes to the design and implemented what @srish said here #904 (comment) |
I understand the complexity. They were just mockups of what I felt the UX should be. The main idea was a separate page for changing passwords, emails, and phone numbers. I guess they can fit on the same page for now and focus on the more important things. |
@srish @tuxology I'm suggesting we should go in for a page for Password change and one for user updates. This will also be different endpoints on the backend for updates and password change. |
I agree. This is the point I've been trying to explain. We can take out the 2FA, Connected devices and email setups for now. |
@mehreeee I like this. Just a few corrections I think you should make: Other than these corrections, love your designs. |
Thank you @DonPresh I have effected the corrections. Quick question does the "forgot password" text look better directly under the current password text box or at the end of the text box? |
@mehreeee end of text box |
Hey @srish @yokwejuste @DonPresh @mehreeee. I still have one doubt here that maybe you can help me solve. |
I'm not sure I understand your question. |
Hey @coderatomy is that on the frontend or backend ? |
Let's go with the design implemented by @mehreeee and @Boluwatifey1 one in which there is an option to retype password too #904 (comment) |
Hey @mehreeee. Can you share the figma link for your mock up |
Sure here's the Figma link |
@coderatomy does it automatically update for mobile too? If no , I can work on the mobile version @srish |
You can just take over with this @JulietMadu, if that's fine with you |
@mehreeee can you place the "forgot password" text underneath the current password box . I feel it will be better that way. |
Hi @JulietMadu the design @srish chose didn’t have the forgot password link under the current text box. Yeah the current and new password text boxes will be empty. Those were just placeholders. |
There is no option for users to be able to change passwords. If the user needs to change the password, they should do it by entering old and new passwords… then the dev can perform a check. I suggest there should be another page or feature for users to be able to change passwords.
The text was updated successfully, but these errors were encountered: