Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLP courses are not in the app #20

Closed
gabriellesc opened this issue Aug 26, 2017 · 0 comments
Closed

HLP courses are not in the app #20

gabriellesc opened this issue Aug 26, 2017 · 0 comments
Assignees
Labels

Comments

@gabriellesc
Copy link
Collaborator

Port of TAPP issue #175: uoft-tapp/tapp#175

@reidka:

The HLP courses appear in the JSON file exported from CHASS, but do not appear in the app after import.

For example, the following appears in the JSON, but I don't see the course anywhere in the app.

        {
            "course_id": "HLP101H1",
            "course_name": "Help Centre TA",
            "round_id": "110",
            "enrollment": "N/A",
            "n_positions": "6",

@gabriellesc:

Would it be possible for @alynch to change the dates input fields in CHASS to date inputs, or something equivalent such that the dates are always in a consistent format?

@reidka:

Maybe. We can ask.

@alynch:

The JSON file has date/time fields of the form:
"last_updated": "2017-07-31 23:57:09"

which is valid ISO_8601 format [1]. What format would you prefer?

[1] (a) The separator between date and time is normally 'T', but it's allowed to omit it by agreement between the parties. (b) We are not using a time zone designator.

@reidka:

Hi @alynch, the field in question sis the "dates" field in the courses. It is a text box in the application, and I filled it in (at least) two different ways.

@alynch:

Oh, sorry, my misunderstanding. Unfortunately the 'dates' field is a text field that departments use to indicate the duration of the appointment, and sometimes they use the field to add extra details. It would be quite a bit of work to convert it to two date fields (and a extra text field for extra info).

@gabriellesc:

@alynch would it be possible to add helptext and/or formatting validation to the field to suggest and/or enforce that the data is entered in a fixed format - while still allowing additional text? For example:

<input type="text" placeholder="dd/mm/yy - dd/mm/yy" pattern="[0-9]{2}/[0-9]{2}/[0-9]{2} - [0-9]{2}/[0-9]{2}/[0-9]{2}.*" />

which would enforce the date format "dd/mm/yy - dd/mm/yy" but allow as much subsequent additional text as desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants