Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser incompatabilities #25

Open
gabriellesc opened this issue Aug 26, 2017 · 2 comments
Open

Browser incompatabilities #25

gabriellesc opened this issue Aug 26, 2017 · 2 comments
Labels
review issue Is it still an issue?

Comments

@gabriellesc
Copy link
Collaborator

Port of TAPP issue #190: uoft-tapp/tapp#190

@lloyd-uot-cs:

Firefox on Windows non-admin account can delete instructors,
but don't get the cursor to type in replacements. Firefox on Windows
admin account works fine

Internet Explorer doesn't work as admin or non-admin

@gabriellesc:

@lloyd-uot-cs Might this have been resolved subsequent to #174?

@lloyd-uot-cs:

You're right! I did a git pull on my test machine and Firefox works now,
but Internet Explorer still has problems with the site...

The IE debugger console says: Error SCRIPT5009: 'fetch' is undefined
File: app-8dacd81794b2a8e58520.js, Line: 1, Column: 109240

Not really sure if that is what's wrong.

@gabriellesc:

@lloyd-uot-cs Is there a way to set up a development/testing environment on my machine with IE? ...Is there even a point supporting IE now that it's being replaced with Edge?

@gabriellesc
Copy link
Collaborator Author

@lloyd-uot-cs we use the fetch API, which is not supported at all by IE: https://developer.mozilla.org/en/docs/Web/API/Fetch_API#Browser_compatibility
However, it is supported by every other browser including Edge.
It might be worth adding a message somewhere that the site is not compatible with IE?

@gabriellesc
Copy link
Collaborator Author

W.r.t. the fetch API, see https://github.com/uoft-tapp/tapp-cp/wiki/Summer2017PostMortem#some-dogs-wont-fetch and https://github.com/uoft-tapp/tapp-cp/wiki/Summer2017PostMortemComments

I'm not sure if there are any other polyfills that we would need?

It might also be worthwhile checking the CSS rendering on browsers other than Chrome (where development happened) and making quick changes if necessary.
(eg. this change was added for compatibility with FF).

@chenjas chenjas added the review issue Is it still an issue? label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review issue Is it still an issue?
Projects
None yet
Development

No branches or pull requests

2 participants