Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer first_time_ta field not set #570

Open
siefkenj opened this issue May 5, 2021 · 0 comments
Open

Offer first_time_ta field not set #570

siefkenj opened this issue May 5, 2021 · 0 comments

Comments

@siefkenj
Copy link
Contributor

siefkenj commented May 5, 2021

The first_time_ta field is never set when a new offer is created. It should probably be set with the following algorithm:

If there is a previous assignment for the TA in the database for a session other than the session whose start date is prior to the current session, set first_time_ta=false. If there is an application for the current session/applicant with either previous_department_ta or previous_uoft_ta set as true first_time_ta=false. Otherwise, first_time_ta=true.

This should probably be done in the active_offers_controller.rb right after the offer is created. (We don't want to put this code in the populate_offer function in the offers model, because it would be strange to have extra database queries in a model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant