Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: revisit test decisions for instructor permissions once the UI is more mature #603

Open
alex-kozin opened this issue May 31, 2021 · 0 comments · Fixed by #599
Open

Comments

@alex-kozin
Copy link
Contributor

There were several instructor permission tests deleted. They were testing querying Ddahs by assignment id and by position id. It was decided best to delete these tests until the UI is more developed to see if they will be useful at all.

The reasoning was that the admin view currently fetches everything on a per-session basis and later on additional filters may be applied. If instructor view follows the same pattern - we would have no need to query Ddahs on a per-position or per-assignment basis.

The goal of this issue is to revisit this decision when the instructor UI is built out to see if we need these tests (and corresponding functionality) or not.

@alex-kozin alex-kozin linked a pull request Jul 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant