Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting emailed_date for a Ddah through instructor/ddahs route should not be allowed #608

Open
alex-kozin opened this issue Jun 11, 2021 · 1 comment
Open

Setting emailed_date for a Ddah through instructor/ddahs route should not be allowed #608

alex-kozin opened this issue Jun 11, 2021 · 1 comment

Comments

@alex-kozin
Copy link
Contributor

alex-kozin commented Jun 11, 2021 •
edited
Loading

Please see "cannot set approved_date/accepted_date/revised_date/emailed_date/signature for a Ddah associated with self" test in instructor-permission-test test file. It is skipped in PR #599 and should pass once this issue is resolved
@alex-kozin alex-kozin mentioned this issue Jun 18, 2021
Merged
siefkenj pushed a commit that referenced this issue Jul 3, 2021
@alex-kozin
Fix DDAH permissions (#612)
e393fe1 
* Fix DDAH permissions.

This PR fixes Issue #608 by restricting which parameters are permitted in ddah controllers for instructors. It also reduces the number of ways one could modify existing ddah by forcing to go through /accept /approve and /email routes instead.

Additionally, some tests are fixed
@siefkenj
Copy link
Contributor

@alex-kozin Did the merged PR fix this issue? Can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siefkenj @alex-kozin