Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking outside the slickgrid does not cause cell edits to save #217

Open
nvernooy opened this issue Oct 19, 2015 · 3 comments
Open

Clicking outside the slickgrid does not cause cell edits to save #217

nvernooy opened this issue Oct 19, 2015 · 3 comments

Comments

@nvernooy
Copy link
Contributor

If a cell is being edited in the slickgrid, and the user clicks anywhere outside the slickgrid, the cell does not update. This could be a problem in the order and valuation modals, where clicking save while still editing a cell could cause its data to be lost.

@nvernooy
Copy link
Contributor Author

@rochecompaan what are your thoughts on this? Is this even an issue?
I thought to automatically commit edits when the grid closes, but maybe the user intentionally wants to discard edits.
Looking at firing a change event while the cell is being edited - mleibman/SlickGrid#680 - seems like it could be hard to implement.
Maybe something like a dialog telling the user there are unsaved edits.

Same goes for the project slickgrid, clicking away causes any uncommited edits to be lost.

@rochecompaan
Copy link
Member

I think it might become and issue but at the moment I feel it is a very very small issue. Personally I use enter to ensure my values are committed and the visual feedback I get when the cursor moves to a new cell is enough to inform me that the change is persisted. Is there anyway to determine the slickgrid loses focus? I don't like the idea of firing a change event while the cell is being edited.

@nvernooy
Copy link
Contributor Author

I don't think there's an easy way to tell when the grid loses focus, but committing cell changes manually is simple. Maybe the simplest would be to inform the user that there is unsaved work and leave it at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants