Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default to nonblock #515

Open
ragurney opened this issue Feb 2, 2018 · 0 comments
Open

Switch default to nonblock #515

ragurney opened this issue Feb 2, 2018 · 0 comments

Comments

@ragurney
Copy link

ragurney commented Feb 2, 2018

We saw Docker connection hanging and Timeout.timeout not helping, would be great if nonblock was the default so that other developers wouldn't run into the same issue.

http://www.mikeperham.com/2009/03/15/socket-timeouts-in-ruby/
https://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/
https://github.com/excon/excon/search\?utf8\=%E2%9C%93\&q\=nonblock\&type\=

I can open the PR if you want.

ragurney added a commit to zendesk/samson that referenced this issue Feb 2, 2018
Startup process was hanging forever and it looked like Docker was responsible. We dug into
the Docker API gem which looked like it was using Excon. It looked like it was using a
blocking connection, so we pass 'nonblock' option to unblock it.

https://github.com/excon/excon/search\?utf8\=%E2%9C%93\&q\=nonblock\&type\=
https://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/
http://www.mikeperham.com/2009/03/15/socket-timeouts-in-ruby/

upserve/docker-api#515
grosser pushed a commit to zendesk/samson that referenced this issue Feb 2, 2018
Startup process was hanging forever and it looked like Docker was responsible. We dug into
the Docker API gem which looked like it was using Excon. It looked like it was using a
blocking connection, so we pass 'nonblock' option to unblock it.

https://github.com/excon/excon/search\?utf8\=%E2%9C%93\&q\=nonblock\&type\=
https://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/
http://www.mikeperham.com/2009/03/15/socket-timeouts-in-ruby/

upserve/docker-api#515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant