Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error processing for rnm-us #23

Open
kflemin opened this issue Apr 13, 2022 · 0 comments
Open

better error processing for rnm-us #23

kflemin opened this issue Apr 13, 2022 · 0 comments

Comments

@kflemin
Copy link
Contributor

kflemin commented Apr 13, 2022

  • when simulation results look like this:
    {
    messages: "",
    results: {
    message: "could not find results file Summary.json"
    },
    simulation_id: "c6d1cec4-fb3b-4393-bcfe-a9f0e8837eee",
    status: "completed"
    }
  1. allow for downloading of the errors.txt file (even if that's the only file that got created)
  2. ensure that all output files were generated before returning a status of "completed" (which kind of implies success).
  3. in rnm-us gem: check that there are results in the response and not just this type of message with no real results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant