Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network seed derivation doesn't take ship parameter #93

Open
Fang- opened this issue Feb 5, 2021 · 0 comments
Open

Network seed derivation doesn't take ship parameter #93

Fang- opened this issue Feb 5, 2021 · 0 comments

Comments

@Fang-
Copy link
Member

Fang- commented Feb 5, 2021

We currently derive the networking seed according to the text of the spec, but not to the figure contained therein.

To clarify: the visual derivation tree in the Urbit Wallet spec shows the ship being included in the salt for networking seed derivation. The text used to describe this, but erroneous editing in urbit/fora-posts#5 mangled the text, excluding (indirect) mention of this.

This matters, because in practice, a single master ticket may own multiple ships, and we will want unique networking keys for all of those. As it stands, owning multiple ships in the same Urbit Wallet will end up with them all using identical networking keys.

Adding this functionality in is desirable, but may break backwards compatibility, depending on how we go about implementing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant