Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend supported data types #418

Open
rongpenl opened this issue May 15, 2020 · 3 comments
Open

Extend supported data types #418

rongpenl opened this issue May 15, 2020 · 3 comments
Assignees

Comments

@rongpenl
Copy link
Contributor

rongpenl commented May 15, 2020

Extend support for additional data types of [properties] (https://rawgit.com/johnsamuelwrites/wdprop/master/datatypes.html) like WikibaseProperty.

Extend ETK so that a property can appear is the value of another property. For example, we want to use https://www.wikidata.org/wiki/Property:P1687 as a label, and the value would be another property, eg

node1 label node2
Q123 P11687 P1234

ETK does not allow data type to be Property

@rongpenl rongpenl self-assigned this May 15, 2020
@szeke szeke assigned saggu and unassigned rongpenl May 18, 2020
@szeke
Copy link
Contributor

szeke commented May 18, 2020

@rongpenl can provide assistance

@szeke
Copy link
Contributor

szeke commented May 18, 2020

@saggu work on this after the experiments for the paper

@rongpenl
Copy link
Contributor Author

@saggu It may not be necessary to make changes in etk, I created a new branch of kgtk: https://github.com/usc-isi-i2/kgtk/tree/enhancement/data_type where I explicitly allows WikibaseProperty to be created as WDProperty defined in ETK. Please use the new wikidataProperty.tsv in data directory as the new property file for test. There are 13 properties are now of data type property, no longer string. P1963 is one of them.

Test input file:

node1 property node2 id
Q1 P1963 P1985 fakeid

I tested the triple creation as well as importing into Blazegraph, it works fine. When you test it, you can update the unit test and merge the branch.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants